Remove insecure API from uv-fastid - #19951
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
| [lib] | ||
| doctest = false |
There was a problem hiding this comment.
cargo shear was complaining about this locally, not sure why it was passing in CI though.
(Not related to the diff otherwise.)
There was a problem hiding this comment.
Are you using the same version as CI? We may need to update either of the two.
There was a problem hiding this comment.
I was on 1.11.2 locally, just upgraded to 1.13.1 and the error disappeared. But it looks like this might have been a true positive, since uv-errors really doesn't contain any doctests.
There was a problem hiding this comment.
iirc we added doctest = false in a bunch of places for test performance, but for cargo shear the 1.13.1 behavior sounds correct, as doctest shouldn't add any new dependencies.
uv test inventory changesThis PR changes the tests when compared with the latest
|
2 participants
Summary
Following #19949 this is unused. We could consider re-adding it after smol-rs/fastrand#130, but the CSPRNG also probably doesn't cost us much here.
Test Plan
NFC.